Fix ANR caused by Duck Player #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
CrisBarreiro
force-pushed
the
fix/cris/duck-player/anr-2
branch
2 times, most recently
from
89679f7
to
e71ec4d
Compare
joshliebe
reviewed
Oct 22, 2024
| val willNavigateToDuckPlayerDeferred = scope.async(dispatcherProvider.io()) { duckPlayer.willNavigateToDuckPlayer(uri) } | ||
|
|
||
| val willNavigateToDuckPlayer = runBlocking(dispatcherProvider.io()) { willNavigateToDuckPlayerDeferred.await() } | ||
| val willNavigateToDuckPlayer = runBlocking(dispatcherProvider.io()) { duckPlayer.willNavigateToDuckPlayer(uri) } |
joshliebe
reviewed
Oct 22, 2024
| @@ -371,6 +373,7 @@ class RealDuckPlayer @Inject constructor( | |||
| } | |||
|
|
|||
| private suspend fun doesYoutubeUrlComeFromDuckPlayer(url: Uri, request: WebResourceRequest? = null): Boolean { | |||
| val start = SystemClock.elapsedRealtime() | |||
joshliebe
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Tested and works as expected! ✅
Just the one comment: #5169 (comment)
CrisBarreiro
force-pushed
the
fix/cris/duck-player/anr-2
branch
from
e71ec4d
to
71012d6
Compare
CrisBarreiro
force-pushed
the
fix/cris/duck-player/anr-2
branch
from
71012d6
to
085784e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1208580918293550/f
Description
DuckPlayerFeatureRepository, as it's no longer needed and we can rely on StateFlows insteadSteps to test this PR
Feature 1